tcp_proxy: remove tcp_proxy_set_idle_timer_immediately_on_new_connection runtime guard#44076
Conversation
…ion runtime guard This flag was added in 1.36.0 and has been defaulting to true for multiple releases. The idle timer is now always started immediately on new connections. Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
Thanks for the review! The previous behavior (not starting the idle timer immediately) was an actual bug that caused connection leaks when the upstream connection wasn't fully established. In my own opinion, there's no legitimate reason to keep the old code path as disabling the guard would mean opting back into a known resource leak(?). This follows the standard Envoy process for runtime guard removal: the fix shipped in 1.36.0, has been defaulting to true for 2 releases, and the changelog entry documents the removal for anyone tracking runtime flag changes. do you have other concerns? |
…ion runtime guard (envoyproxy#44076) Commit Message: This flag was added in 1.36.0 and has been defaulting to true for multiple releases. The idle timer is now always started immediately on new connections. Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
2 participants
Commit Message:
This flag was added in 1.36.0 and has been defaulting to true for multiple releases. The idle timer is now always started immediately on new connections.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]